Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Coverity] GPU Plugin Medium issues #27761

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Coverity] GPU Plugin Medium issues #27761

wants to merge 2 commits into from
+6 −3

Conversation

mhpanah
Copy link
Contributor

@mhpanah mhpanah commented Nov 26, 2024

Details:

  • This PR fixes: 1562334, 1559879, 1559863, 1559854, 1559677
  • In PR 27071, We explicitly called the base class constructor to resolve an issue similar to the following CIDs. Need to further investigate: 1559461, 1559460, 1559886, 1559881, 1559862, 1559698, 1559691, 1559879 and 1559863.

Tickets:

@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Nov 26, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalIntelPR External contributor from Intel label Nov 26, 2024
@p-durandin
Copy link
Contributor

buid_jenkins

p-durandin
p-durandin reviewed Nov 27, 2024
View reviewed changes
...ns/intel_gpu/src/kernel_selector/kernels/fully_connected/fully_connected_kernel_bf_tiled.cpp Outdated
if (quantize_grp_size == 0) {
std::cerr << "Error: quantize_grp_size is zero." << std::endl;
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use exception or assert here

...ns/intel_gpu/src/kernel_selector/kernels/fully_connected/fully_connected_kernel_bf_tiled.cpp Outdated
@@ -941,6 +946,11 @@ KernelsData FullyConnected_bf_tiled::GetMultiKernelsData(const Params &params,

size_t quantize_grp_size = get_dynamic_quantize_group_size(fc_params);

if (quantize_grp_size == 0) {
std::cerr << "Error: quantize_grp_size is zero." << std::endl;
return KernelsData();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use exception or assert here

@p-durandin p-durandin marked this pull request as ready for review November 28, 2024 06:05
@p-durandin p-durandin requested review from a team as code owners November 28, 2024 06:05
@p-durandin
Copy link
Contributor

build_jenkins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-durandin p-durandin p-durandin approved these changes

Assignees
No one assigned
Labels
category: GPU OpenVINO GPU plugin ExternalIntelPR External contributor from Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhpanah @p-durandin @sys-openvino-ci